Skip to content

Improve selex pattern age size bin description#288

Merged
e-perl-NOAA merged 6 commits intomainfrom
selex-pattern-age-size-bin-description
May 19, 2025
Merged

Improve selex pattern age size bin description#288
e-perl-NOAA merged 6 commits intomainfrom
selex-pattern-age-size-bin-description

Conversation

@e-perl-NOAA
Copy link
Collaborator

Implement suggested changes by @jimianelli related to ss3-source-code PR #670

Workflows addition of concurrency lines to cancel workflows if another push is made on the same branch - this is something some of us are starting to implement across nmfs repos.

@e-perl-NOAA e-perl-NOAA added documentation Improvements or additions to documentation Manual workflows related to workflows/gh-actions labels May 15, 2025
@github-actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps:
The low and high bin numbers are listed BEFORE the bin specific parameters

Also add:
Selectivity values greater than 1.0 can occur with this approach. Corresponding offsets in catchability or F values will occur.

@e-perl-NOAA
Copy link
Collaborator Author

@Rick-Methot-NOAA maybe 'BEFORE the bin-specific parameters and other selectivity parameters' or maybe 'the order of the parameters for this option is as follows: low and high bin numbers, bin-specific parameters, other selectivity parameters'

I just want to make sure that it's clear that all that goes before the other selectivity parameters.

@github-actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@Rick-Methot-NOAA
Copy link
Collaborator

There are no other selectivity parameters for that fleet, so I worry that mentioning other in that way might invite confusion rather than emphasis.
So, I'd be OK with either:
The low and high bin numbers are defined BEFORE the bin-specific parameters for that fleet.
or
The low and high bin numbers are defined BEFORE the other parameters for that fleet.

@github-actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@e-perl-NOAA e-perl-NOAA merged commit b62b978 into main May 19, 2025
6 checks passed
@e-perl-NOAA e-perl-NOAA deleted the selex-pattern-age-size-bin-description branch May 19, 2025 19:39
@github-actions
Copy link

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Manual workflows related to workflows/gh-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants